Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix usage of folder and directory terms in fs.md #32919

Closed
wants to merge 1 commit into from
Closed

doc: fix usage of folder and directory terms in fs.md #32919

wants to merge 1 commit into from

Conversation

karan1205
Copy link
Contributor

@karan1205 karan1205 commented Apr 18, 2020 •
edited
Loading

This commit fixes the interchangeably usage of "folder" and "directory"
terms in fs.md

Fixes: #32902

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@karan1205
doc: fix usage of folder and directory terms in fs.md
2f106c1 
This commit fixes the interchangeably usage of "folder" and "directory"
terms in fs.md

Fixes: nodejs#32902
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Apr 18, 2020
juanarbol
juanarbol approved these changes Apr 18, 2020
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the help!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30839/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30853/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30854/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30857/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/30863/

@puzpuzpuz puzpuzpuz added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 20, 2020
puzpuzpuz pushed a commit that referenced this pull request Apr 21, 2020
@karan1205 @puzpuzpuz
doc: fix usage of folder and directory terms in fs.md
b53cae3 
This commit fixes the interchangeably usage of "folder" and "directory"
terms in fs.md

Fixes: #32902

PR-URL: #32919
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@puzpuzpuz
Copy link
Member

Landed in b53cae3

Thanks for this improvement!

@puzpuzpuz puzpuzpuz closed this Apr 21, 2020
BethGriggs pushed a commit that referenced this pull request Apr 27, 2020
@karan1205 @BethGriggs
doc: fix usage of folder and directory terms in fs.md
68b7c80 
This commit fixes the interchangeably usage of "folder" and "directory"
terms in fs.md

Fixes: #32902

PR-URL: #32919
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 27, 2020
Merged
BridgeAR pushed a commit that referenced this pull request Apr 28, 2020
@karan1205 @BridgeAR
doc: fix usage of folder and directory terms in fs.md
76e960c 
This commit fixes the interchangeably usage of "folder" and "directory"
terms in fs.md

Fixes: #32902

PR-URL: #32919
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Apr 28, 2020
Merged
targos pushed a commit that referenced this pull request Apr 30, 2020
@karan1205 @targos
doc: fix usage of folder and directory terms in fs.md
ee9d25b 
This commit fixes the interchangeably usage of "folder" and "directory"
terms in fs.md

Fixes: #32902

PR-URL: #32919
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request May 2, 2020
Merged
targos pushed a commit that referenced this pull request May 13, 2020
@karan1205 @targos
doc: fix usage of folder and directory terms in fs.md
26cf6a3 
This commit fixes the interchangeably usage of "folder" and "directory"
terms in fs.md

Fixes: #32902

PR-URL: #32919
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@devnexen devnexen devnexen approved these changes

@himself65 himself65 himself65 approved these changes

@trivikr trivikr trivikr approved these changes

@juanarbol juanarbol juanarbol approved these changes

@yozaam yozaam yozaam approved these changes

@puzpuzpuz puzpuzpuz puzpuzpuz approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using "folder" and "directory" interchangeably in documentation
9 participants
@karan1205 @nodejs-github-bot @puzpuzpuz @cjihrig @devnexen @himself65 @trivikr @juanarbol @yozaam